Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device settings search #758

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Device settings search #758

wants to merge 14 commits into from

Conversation

strongville
Copy link
Contributor

@strongville strongville commented Apr 8, 2024 •
edited
Loading

  • This will let search for and open the most common settings across AOSP that would be available on the device.
  • At the moment there's no intention to add any One-UI/MIUI/etc. custom settings page because they won't be functional for all users and it's not certain if we can discriminate settings querying for the info of the device without adding special or invasive permissions on the app.
  • Settings should appear if you search for "settings" or for the title, both localized.

Supported settings on this provider:

  • Accessibility: android.settings.ACCESSIBILITY_SETTINGS
  • Airplane mode: android.settings.AIRPLANE_MODE_SETTINGS
  • All apps: android.settings.MANAGE_APPLICATIONS_SETTINGS
  • Battery: android.intent.action.POWER_USAGE_SUMMARY
  • Bluetooth: android.settings.BLUETOOTH_SETTINGS
  • Development: android.settings.APPLICATION_DEVELOPMENT_SETTINGS
  • Device info: android.settings.DEVICE_INFO_SETTINGS
  • Display: android.settings.DISPLAY_SETTINGS
  • Kvaesitso (same as settings on dotted menu)
  • Location: android.settings.LOCATION_SOURCE_SETTINGS
  • NFC: android.settings.NFC_SETTINGS
  • Security: android.settings.SECURITY_SETTINGS
  • Sound: android.settings.SOUND_SETTINGS
  • Storage: android.settings.INTERNAL_STORAGE_SETTINGS
  • System updates: android.settings.SYSTEM_UPDATE_SETTINGS
  • Tethering (action com.android.settings.TetherSettings for com.android.settings package)
  • Wi-Fi: android.settings.WIFI_SETTINGS
  • Wireless connection: android.settings.WIRELESS_SETTINGS

List of settings on Kvaesitso

@strongville
Initial setup for Settings search.
22be534 
Signed-off-by: Guillermo Villafuerte <[email protected]>
@strongville
Open launcher settings as "special" case.
6b0eda0 
Signed-off-by: Guillermo Villafuerte <[email protected]>
@strongville
Settings moved before app shortcuts.
baf62a4 
Signed-off-by: Guillermo Villafuerte <[email protected]>
@strongville
First batch of settings, heavily based on KISS Launcher list.
7f312bf 
Signed-off-by: Guillermo Villafuerte <[email protected]>
@strongville
Small refactor, including current icon.
c4fd4fb 
Signed-off-by: Guillermo Villafuerte <[email protected]>
@strongville
Merge remote-tracking branch 'origin/main' into feat/settingsSearch
59890f9
@strongville
Merge remote-tracking branch 'origin/main' into feat/settingsSearch
2648b40 
Signed-off-by: Guillermo Villafuerte <[email protected]>

# Conflicts:
#	app/ui/src/main/java/de/mm20/launcher2/ui/launcher/search/SearchColumn.kt
#	app/ui/src/main/java/de/mm20/launcher2/ui/launcher/search/SearchVM.kt
#	services/search/src/main/java/de/mm20/launcher2/search/SearchService.kt
@strongville
"Settings" word and title are now split.
20da053 
Signed-off-by: Guillermo Villafuerte <[email protected]>
@strongville
Removed settings title placeholder.
0ae4e69 
Signed-off-by: Guillermo Villafuerte <[email protected]>
@strongville
Merge remote-tracking branch 'origin/main' into feat/settingsSearch
2582058 
# Conflicts:
#	core/preferences/src/main/java/de/mm20/launcher2/preferences/LauncherSettingsData.kt
#	core/preferences/src/main/java/de/mm20/launcher2/preferences/Module.kt
@strongville strongville marked this pull request as ready for review April 22, 2024 01:49
@strongville
Minor icon tweaks.
eab2919 
Signed-off-by: Guillermo Villafuerte <[email protected]>
@strongville
Merge remote-tracking branch 'origin/main' into feat/settingsSearch
701cf45 
Signed-off-by: Guillermo Villafuerte <[email protected]>

# Conflicts:
#	app/ui/src/main/java/de/mm20/launcher2/ui/launcher/search/filters/SearchFilters.kt
#	app/ui/src/main/java/de/mm20/launcher2/ui/settings/search/SearchSettingsScreenVM.kt
@strongville
Merge remote-tracking branch 'origin/main' into feat/settingsSearch
a8c8995 
# Conflicts:
#	app/ui/src/main/java/de/mm20/launcher2/ui/launcher/search/filters/KeyboardFilterBar.kt
@strongville
Merge remote-tracking branch 'origin/main' into feat/settingsSearch
b422c32 
Signed-off-by: Guillermo Villafuerte <[email protected]>
@TimoNotThy
Copy link

Is it not possible to somehow add the results of the search function of the settings app instead? That way it would also include the custom settings from One-UI/MIUI/custom roms/etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strongville @TimoNotThy